I can only imagine this happening with external constraints such as parsing the output to perform a DB check, so I'm curious.
75 karma · joined November 25, 2020
I can only imagine this happening with external constraints such as parsing the output to perform a DB check, so I'm curious.
Anyway, this is your first job and you are playing a very long game. Don't let a single interaction determine how you feel. As many others already mentioned, you can also talk about it with your manager to figure out what happened.
The last one I got felt too arbitrary: I decided to improve the behavior of an unused feature from one of our core libraries to unblock a colleague working in the application. The change was straightforward and it took me 1hr to get it into a PR. The feedback was that we should keep the old behavior available, just in case. So I spent a full afternoon wrangling C++ templates to fit in a new API that offered both the improved and old behavior for which there is no requirement.
What started as a small detour from my regular work to help a fellow engineer ended up costing me a day.
In the end, I told my colleague that he would have to take over the PR as I had lost too much time on it. Sure enough, he had to change all parameter names cause the types already describe them well enough: `foo(Timeout connection_timeout)` -> `foo(Timeout connection)`.
The resulting code looks great, but now it is clear that I have a more pragmatic style. I recognize that I simply failed to stand my ground, and I'll take that into account.
Although I push for a lot of upfront agreement, most of the back and forth arises from little things, like a variable name being too long, a newline between struct members, or a docstring that could be removed because the code is expressive enough.
I'm usually okay with all of these suggestions. Still, lately, I'm fell in a position where usually the person who reviews my code is our architect (an amazingly talented engineer). He always flags all the minutiae (very politely, of course), and I find it very hard not to comply as I want to ship better stuff.
Funnily enough, a few days ago, I found myself reviewing a colleague's PR and repeating the same behavior. As soon as I saw myself doing it, I deleted these comments, made the suggestions that I judged valuable, and approved.
Thanks for the input! Just replying gave me a lot of clarity on the subject.
Just make sure to store any emails and support protocols that indicate that the account was recognized as hacked. This will be important if you ever have to deal with the debt in mediation/court.
Thankfully, a buddy of mine pointed me to SetupDiag, which parses the logs to get you more info. In the end, the update was failing due to an accelerometer driver (!!).
I went through burnout, and quitting the job/career that was draining me, was enough to remove the weight off my shoulders and give me some clarity.
This all assumes you have financial means do to so (for me, it took 4 months), and if that is not the case, I suggest preparing yourself for it.
The only true delusion of grandeur is thinking that dwindling others' experiences against the vastness of the universe is enlightenment: If we don't experience our existence in geological/cosmic time scales, why waste time believing we are mere blips?
Out of curiosity, could you elaborate on that?