I checked out your website and found it quite abstract, I understand enforcing team standards on each PR but I don't see more meat beyond that for reviews. Would be keen to see what y'all do in the review space!
37 karma · joined April 2, 2020
I checked out your website and found it quite abstract, I understand enforcing team standards on each PR but I don't see more meat beyond that for reviews. Would be keen to see what y'all do in the review space!
Everyone reviews PRs differently but I've personally started relying more on visualisations to get an initial sense of what's happening. So this is my attempt at a skill and a UI kit to help me understand PRs faster. Bugbots help find bugs, but the primary purpose of reviews is to build shared understanding! Shoutout to Blake Smith (https://blakesmith.me/2015/02/09/code-review-essentials-for-...).
I'd love to get HN's take on this :)
Everyone reviews PRs differently but I've personally started relying more on visualisations to get an initial sense of what's happening. So this is my attempt at a skill and a UI kit to help me understand PRs faster. Bugbots help but not really because the purpose of reviews is to build shared understanding! Shoutout to Blake Smith (https://blakesmith.me/2015/02/09/code-review-essentials-for-...).
I'd love to get HN's take on this :)
I don't have the exact CPU/bandwidth numbers on me right now but CPU usage has went up by about ~50% on our "Ingester" and "Compactor" components (you can read up about the architecture here - https://grafana.com/docs/tempo/latest/operations/architectur...). But this is optimising for read performance which improved significantly.
The relevant code for parquet storage backend can be found here: https://github.com/grafana/tempo/tree/main/tempodb/encoding
disclosure: I work for Grafana!