I had some system performance problems a while back and their phone support talked to me immediately and helped me through the troubleshooting process very clearly, again after I was out of warranty. No charge.
ICloud is a bit expensive so I don’t use it, but there are plenty of alternatives. I use Dropbox and Google Drive. I can see the convenience being worth it for some people. Let the market decide.
Apple gear is pricey, but I’ve never really felt nickel and dimed. I know some people have bad experiences, but for me once I’ve bought their stuff I’ve got excellent and quite generous after sales support.