HNHacker News
TopNewBestAskShowJobs

krawaller

9 karma · joined August 30, 2014

submissionscomments
krawaller··on A React.js case study
There's now a follow-up to this post, walking through a refactor based on the comments given here and elsewhere. Thank you all for the feedback!

https://news.ycombinator.com/item?id=8273026

krawaller··on A React.js case study
Wow, thank you so much for this! Reading through your changes I do feel a bit silly. And wiser! :)
krawaller··on A React.js case study
The not doing anything is intentional - only when the pair is resolved and the status row goes back to saying "choose a tile" can you click a new tile. This "feature" really needs to be communicated better though, sorry abouy that.
krawaller··on A React.js case study
I touch on this in a post - I did try the latter, but got a React warning in the console about unmounted components. That, together with a comment in the official docs, made me go with the show/hide approach.

Although as pointed out in the Disqus comment, choosingg what to render is also fine, I probably did something silly stemming from not fully understanding the component life cycle.

krawaller··on A React.js case study
Might be I've been sloppy with adding -moz- to some css rules. Will take a look!
krawaller··on A React.js case study
Oh, indeed, I've completely missed the classSet plugin! That would indeed make the code more elegant. And fair point about the logic perhaps being too complicated here.

Thanx for the pointers!