This is how my office life is..
349 karma · joined January 29, 2015
This is how my office life is..
Very rarely I get stuff that is so badly made, or naively implemented that I just have to say no, then go help the person redesign the solution. This happens rarely though, maybe twice a year with a fresh employee.
If the code is not formatted to the linter, it should not have been submitted for review and I will probably reject it. We have to hold our work to some kind of standard.
Otherwise I do the "I did not understand this, can you please explain?" Quite a bit if a part is confusing.
I try to invite to a discussion, not demand doing it to my taste and make it clear a lot of the comments are suggestions for future work.
That is not how we made our legislation work.
I have seen it too many times with project managers and now my CTO. Trying to still code and fix that terrible bug with already too little time. Ends up slowing down everyone because he never can get anything finished, or breaking things on a Thursday at 6:49pm because of the half baked solution he thought was good enough, but exploded in production, which he then has to spend 1 more hour fixing and 6 more hours cleaning up the aftermath. Spend your time reviewing and mentoring and try replacing yourself with someone who has time.
You now have important shit to do.
I think gitlab are doing a pretty good job with their product.
I often _redesign_ old code to meet new requirements and to support new features, but I would not call it refactoring.
I always strive to leave the code better than when I found it. But I would not name it refactoring.
Also realized, this is a bit analogous to how Bitcoin works. In Bitcoin _every_ other node in the network will validate (audit) some proposed work. If at least 51% of the nodes in the network agree that some piece of work is valid, it has a good chance of becoming part of the permanent history (next block on the chain).
Drug cartels probably spent a lot of money getting out of legal trouble and dealing with international police
Or inversely: if the data presented are complex and convoluted, you will need mountains of docs to try explain its design.
Also noting that the semantic UI docs still give a horrible mobile experience (iOS 11).
The quicker pace with smaller changes will hopefully help with this friction.
You need packaging, update scripts, init scripts and strict policies for upgrades and do coordinated library updates (on the shared environment), or nearly roll your own os where you bundle your dependency with the app. That is incredibly time consuming.
With containers you don't need init scripts, the team can update any dependency when they want/need without breaking someone elses environment. And with containers every team deliver the same 'thing', a runnable image. Not a blob of php, some ruby and java ear and wars that have to run on a shared platform.
Are there any sources where I can read more? I know Google fought a lot over similar issues and eventually withdrew their hardware from China.
Also, the Chinese are building a citizen scoring card system, that will rate your standing with the government from birth to death.