43 karma · joined August 27, 2012
[ my public key: https://keybase.io/kellner; my proof: https://keybase.io/kellner/sigs/dvMay79hR1Yivux7brVALrWopj-WZ0Dgg5f4HBJD_kk ]
May point about the script was more that it also just disables the two things listed in the initial privacy info given by Apple, i.e. "MENU_WEBSEARCH" and "MENU_SPOTLIGHT_SUGGESTIONS" and having informative text with screenshots to which checkboxes to unselect on the website would have sufficed. At least you wouldn't be executing code from some random place on the internet.
"In addition to searching your Mac, Spotlight now shows suggestions from the Internet, iTunes, App Store, locations nearby, and more. To make suggestions more relevant to you, Spotlight includes your approximate location with search requests to Apple. You can change this in Preferences. Learn more…"
Clicking on "Learn more" also tells you how to disable it. The python script is neat but a bit exaggerated IMHO.
I can assure you that I have been angry about (my own and others) working but ugly code more often than not, because at some point you lose control and then you don't even understand what is going on anymore. Try making another 'quick' modification to the source base then. Oh and don't forget the fun to read some other PhD student's (scientific quick hack) code, who isn't even in the lab anymore.