36 karma · joined May 11, 2013
I think it's based on Fedora but I haven't tested it myself yet so I'm not sure.
From a cursory glance:
1. https://github.com/timothyej/Shortfin/blob/master/src/reques...
should be (data_len - i >= 4) since it accesses data[i+3]
2. https://github.com/timothyej/Shortfin/blob/master/src/reques...
shouldn't headers[header_count]->key also be null terminated?
3. https://github.com/timothyej/Shortfin/blob/master/src/reques...
header_count can become greater than 49 which causes a heap overflow at https://github.com/timothyej/Shortfin/blob/master/src/reques... and https://github.com/timothyej/Shortfin/blob/master/src/reques...
--- The reason is that these settings make no sense. Why should a terminal be transparent, or have an image behind everything, but the same not apply to, say, gedit, or firefox, or evolution?