HNHacker News
TopNewBestAskShowJobs

_jg

172 karma · joined October 16, 2019

submissionscomments
_jg··on Hacking GitHub's Auth with Unicode's Turkish Dotless 'I'
Should be: 'John@Gıthub.com'.toUpperCase() === 'John@Github.com'.toUpperCase()
_jg··on Hacking GitHub's Auth with Unicode's Turkish Dotless 'I'
Our team at Wisdom has done the exact same. It's been confusing at times, but much better once we got going.
_jg··on Hacking GitHub's Auth with Unicode's Turkish Dotless 'I'
This was a very real and demonstrated vulnerability. Perhaps I've misunderstood your comment.
_jg··on Hacking GitHub's Auth with Unicode's Turkish Dotless 'I'
Unfortunately convention has normalised user expectations that email addresses are now case-insensitive. It's now a standard business requirement. Too bad few devs fully handle Unicode.
_jg··on Hacking GitHub's Auth with Unicode's Turkish Dotless 'I'
Yes! Add in a toLowerCase() in there as well.

An apparently small deviation with surprisingly large repercussions.