Xelank

Thanks for the links! Having a list of cool PRs definitely helps conversion :)

Thanks for your input. There definitely is a lot of back and forth and I consider it a very good thing. It's interesting because it's a chicken-and-egg problem - if your tool is painful to use, then team members are less likely to participate seriously.

(What I'm really wondering though is whether incremental code reviews are specific to the pre-commit model. In theory I don't think this is the case since tools like Upsource has it as well)

Anyway, what was your experience migrating the team to Phabricator? What's the general workflow from starting a new feature to getting it to prod? Cheers

reviewable is probably my favourite at the moment which ticked all my boxes, though it involves switching over to github which may or may not happen.

Do you have any more advanced example of real code reviews using reviewable? Seems like there isn't a easy way to find more advanced examples (I found one particular one for Rust, but I can't seem to find a way to navigate to other code reviews of the same project)

What code review tool do people actually use for a PR-based workflow? My company has been recently looking for better code review tools than Bitbucket's.

A few key features I'm looking for:

- Incremental review: show what files has changed since last review (ideally what lines)

- Timeline view: See what have happened since you last reviewed it

- Custom "PR Approved" rules + indicator: e.g. 3 approvals + build passed. This gives us an easy way to see whether a change is ready to be merged and released.

A lot of these features can be found in (what seems to me to be) trunk-based, pre-commit style tools like Phabricator and Gerrit. However I'm not sure whether the extra tooling (i.e. ramp up cost and complexity) is worth the return. Does anyone have any experience as to how switching over yielded good gains?

Great analysis here. Really shows our double standard and mob mentality.

I'm not against people boycotting Mozilla (because that's their choice) but the whole things is just a big hotheaded mobfest (like all the other mobfest in the past).

Double standards here. You wouldn't be against anyone who donated to the cause because you think it's 'right'.

Now substitute 'gay marriage' with 'legalizing drugs'. See where your argument is going?

"He's wrong because he doesn't agree with me and took action to oppose it". If people never took action to push their beliefs then we'll still have slavery in USA.

We're a democratic society, and people are free to voice their opinion or donate to campaigns that support their beliefs as long as it is legal.