HNHacker News
TopNewBestAskShowJobs

IsBisu

2 karma · joined December 8, 2016

submissionscomments
IsBisu··on WinFsp – FUSE for Windows – faster Than Dokany
>Mapping = CreateFileMappingW(Handle, 0, PAGE_READWRITE, 0, FileSize, 0);

So it is more a "case" not handled by dokan rather that all memory mapped not handled ? Is this made in purpose just to remove dokan from the bench ?

>The lock exists on WinFsp/MEMFS. It is just taken in a different place:

It changes nothing on what I said. You added it on dokan side without reason and not on winfsp memfs.

>send me any pull requests that you want for Dokany/MEMFS

A pull request will not change that a real application on a non-virtual machine will not see the difference.

IsBisu··on WinFsp – FUSE for Windows – faster Than Dokany
I agree. It would even be more interesting or reliable if the benchmark could compare a MEMFS made by dokan author and not Winfsp author like here.
IsBisu··on WinFsp – FUSE for Windows – faster Than Dokany
You say in your bench that Dokan support does not support memory mapped files but it does as I can see with fsx (memory mapped read/write enabled) running on their CI https://ci.appveyor.com/project/Maxhy/dokany/build/1.0.1-48/... It is your implementation that doesn't support it.

You add lock (that will slow down the result) on Dokan implementation only https://github.com/billziss-gh/memfs-dokany/commit/03ebaebb1... After that you see that dokan is faster to list files (https://github.com/billziss-gh/winfsp/commit/595a77bd2e45347...) You improve YOUR MEMFS winfsp implementation https://github.com/billziss-gh/winfsp/commit/f7ca9f05221040a... but not on dokan ?

You also improve memory allocation on winfsp memfs implementation and again not on dokan https://github.com/billziss-gh/winfsp/commit/d12234bb01b3620...

And last point...running it on VirtualBox O_o ? Even running it 5x time and take the best time. You cannot be sure that virtualbox has not corrupt your test. For me a benchmark on a VM is not reliable at any point.

My point is even if Winfsp is fast on your test with an unfair FS, I am pretty sure there is not difference with real applications on a non-virtual machine.

IsBisu··on WinFsp – FUSE for Windows – faster Than Dokany
You should better say that your userland FS is fast with WinFSP that with Dokan https://news.ycombinator.com/item?id=13129215
IsBisu··on WinFsp – FUSE for Windows – faster Than Dokany
SSHFS has been on windows since a moment with Dokan https://github.com/Foreveryone-cz/win-sshfs
IsBisu··on WinFsp – FUSE for Windows – faster Than Dokany
You should better say that YOUR MEMFS implementation is better on Winfsp that YOUR MEMFS implementation on Dokan. This is even not a far comparison.