The benefit from additional discoveries is already factored into the cost of conventional solar. The companies building it have business plans that recognize the development work they're doing, and charge prices accordingly. And that's part of why it's cheap (relative to this proposal) and getting cheaper.
Indeed, but the type of jobs generated by these types of projects are hardly pointless ditch digging.
The benefit from additional discoveries is already factored into the cost of conventional solar.
But only if the companies are Japanese. Otherwise Japan is not only helping grow another countries GDP they're also helping them gain a further technology lead. Doing everything 'in house' is probably more inefficient in the short term, but might offer more long term benefits.
In this case, certainly the whole world would benefit even if a better solar energy technology (conventional or outer space) were invented. The polio vaccine helped the whole world; the reason that most of the revenue from it came to the USA is that the rest of the world thought that having those shots was more important than giving up their money.
And in economic terms, if tilting the economies of scale makes Japan a better manufacturer of solar power tech, then the law of comparative advantage allows other countries to benefit from supplying the goods that Japan will shift away from as it moves resources to the solar tech.
Then I think that Japan, currently the world's #2 solar market (Germany is #1), should be investing in thin film solar R&D for the reasons you listed.
In thin film, Japan (in the form of Sharp's second generation amorphous silicon panels) is getting its ass kicked by First Solar's CdTe panels. I think that investing in, for example, CIGS or CdTe technology would be a better investment.
If it's government funded/subsidized it's more likely to divert capital from more productive R&D and uses in the economy.
However, it is an oversimplification. As stated, it doesn't account for externalized costs, that is, costs of the product that are not borne by the seller.
For example, the energy industry has historically benefited because part of the cost of their product -- that is, the damage done by pollution -- is not paid for in the sale of the energy, but is borne by the public at large. Thus, the cost of pollution has gone into the coffers of the energy suppliers (and their stockholders). This is the inequity that legislation such as cap-and-trade try to alleviate (not that I'm a fan of this legislation by any means, the gov't is just as bad).
But from history of man kind seems that investing in new things and even exotic research is in the long run extraordinarily beneficial.
Gains from gathering resources and building ITER (or GPS, or orbital power plant) earlier not later can give humanity much greater benefit than it would gain from instantiating 5 mln startups with 1/5mlnth of the used resources.
I'd even say that no value can be created by human activity (by means other than resource exploitation) if it does not involve inventing or applying new technology.