Hacker News Reader

Comment by PeterGriffin | Hacker News Reader

I didn't have time to review the project in detail, but one thing that made an impression on me is having a registry in there.

Many projects make the same mistake. The registry/service locator/DI container or whatever flavor you prefer should be an application concern.

Applications should create this for themselves, and not every library having its own registry just for instances of its own classes.

Similarly you have factories and builders which wrap a constructor and don't add or change anything. You can remove some of that code and focus on the essence of your library. This way it might gain more supporters and contributors.

View on HN

I absolutely agree with you about applications using their own DI/IOC implementations.

The registry in this library, however, isn't meant to be a registry used outside of the internals of the library. It's an unfortunate side effect of trying to marry up object instances with PHPs static stream wrapper API.

Oh I see.

I wish PHP had visibility for classes, oh well.

Do you know what I do, I put everything that's not meant to be used by "the public" in sub-namespace "Internal". So, say "Vendor\Project\..." for public classes and "Vendor\Project\Internal\..." for volatile internal matters.

This means there's no confusion about what people should use, and what's just the guts of the system they shouldn't mess with.

I personally think it's neater to mark the class with an @internal PHPDoc tag rather than add a sub-namespace.

http://phpdoc.org/docs/latest/references/phpdoc/tags/interna...

It's an option, and it sure is neater to those creating the library, but it's much less neater to those using it. Not everyone compiles a PHPDoc for themselves when downloading a library, so then all classes form a nice big pile at the root namespace.

In terms of neatness and ease of use, I choose like I'd choose how to optimize code - I focus on the parts that get most use. Users of a library are hopefully way more than its maintainers, so it feels like it's worth slightly inconveniencing the maintainers in order to have an instantly clear public interface.

Reply on news.ycombinator.com