Defining a function for is_file as [[ -f $blah ]]; seems like defining a function for var++ as increment_one() ...
But to some of my coworkers who don't write shell very often at all, it would make the script far clearer (which is useful as they need to be able to edit it on the fly) to those who don't know shell
You should always remember who you're writing for and write accordingly. Hint: you almost never write for the computer.
$ test -f "$file"
is pretty clear I think.