Comment by codez | Hacker News Reader

Comment by codez | Hacker News Reader

Parent Full thread

Thanks for the feedback lobster_johnson!

Yes, I'd be more than happy to provide a SASS version, I'll look into that, hopefully this evening as it shouldn't be too long to make one at all.

Do you feel the documentation gets across what can be done with it clear enough?

For instance, This doesn't need a js dependency but you could easily mock progress using a keyframe animation on a particular progre(c)ss etc. I am going to try and make some clearer docs and try add some feature attributes, or classes.

I just want it to be clear to people that you can add it to existing elements I think without changing design.

Thanks again for the feedback and I'll get a SASS file in as soon as I can.

I would definitely emphasize that it's pure CSS, because it wasn't obvious to me when I looked. Instead of

    custom css progress bars with minimal effort!

you could write:

    Pure CSS progress bars with minimal effort!

(Yeah, the lack of capitalization looks a bit shoddy to me.)

Aside from that, it looks great. That said, I think a JavaScript helper to complement it would be great; I am using NProgress in several apps, and I like the fact that I can just start and stop it, and it will just do its thing.

Ok that's cool. I will look to add a helper and the SASS file.

I've changed the sub heading ;)

Thanks for this.

added sass version.

That was fast. Great! And thanks!

No problem :)

I'll look into mocking stuff and adding the js helper.

Shouldn't take too much time I don't think.

Reply on news.ycombinator.com