The market share of Windows Phone 8 is extremely small and doesn't seem to pick up.
The PC market is shrinking extremely and many analysts now point to Windows 8 as one of the reasons behind that. You can point to a 10 minute learning curve and while I agree that the new Windows interface is not hard to learn I still think it's an extremely bad user experience. The standard apps are just so incredibly bad (e.g. the mail app, the photo app, the video app, even the store itself) that I'm not using them at all. I spend 99.9% of my time on the old Windows desktop.
The market share of the Surface again is extremely small and I don't see any indications of it growing.
I totally agree that competition is good for the customer (and might potentially be bad for competitors), but so far that doesn't help Microsoft.