Faster prompt lookup drafting in llama.cpp | Hacker News Reader

Faster prompt lookup drafting in llama.cpp

jadidbourbaki.github.io

89 pointspptadversary12 comments

Btw, if anyone has experience with the open source community in general and llama.cpp in specific, I would greatly appreciate some advice. I’m facing a bit of an interpersonal issue that I really hope is resolved without any ill will. Here is the context:

https://www.reddit.com/r/LocalLLaMA/comments/1wr5ylm/comment...

Any advice for what I can do? Due to this, I cannot create a PR or issue in the llama.cpp repository. However, I am worried about bothering the maintainers on other channels in case it aggravates them further. Thank you for your help!

hopefully someone on the team sees this and fixes the situation, otherwise, if it's good, i'm sure somebody else will open the PR. thanks for your contribution.

I understand this repository must be under siege effectively with how popular it is, but the team needs to come up with a decent way to handle this. The current climate with Nvidia buying Hugging Face who effectively owns the llama.cpp team there’s a lot of discourse around their control of the team that’s negative.

Just hard fork the project. Frankly, llama.cpp is so badly written that these kind of speedups are trivial, and a hard fork (or a total rewrite) has been needed for the longest time.

> Any advice for what I can do?

Email that author (email can usually be found via GitHub, or contact via other private way they've shared somewhere) and explain the situation, don't lambast them publicly on social media or similar ways. If that doesn't work, do the same but for another maintainer. Don't spam all of them straight up, wait a week or something before contacting someone else.

That would be inadvisable as the maintainer (?) in question's GitHub bio states:

> Emailing me about a temporary ban will result in a permanent one instead.

As far as I can tell the ban was given based on a single accidental ping to the maintainer, who then reviewed the draft PR before realizing it was not for the mainline llama.cpp repo.

Fun update to this: Daniel Lemire added another optimization to make this even faster. https://github.com/jadidbourbaki/llama.cpp/pull/12

I’ll benchmark his change and add it to the article, crediting him for this improvement.

As an update to this, Lemire absolutely crushed it! I benchmarked his change today. Here is my PR comment:

https://github.com/jadidbourbaki/llama.cpp/pull/12#issuecomm...

How much does this speedup inference for the end user in terms of tk/s ?

So, instead of resolving it privately like you were asked, you come here and complain? Was the bot posts on Reddit not enough for you? Pro tip: There is a right way and a wrong way to approach these things and you are MOST certainly approaching this the wrong way. And before you go accusing me of anything: I am NOT associated with that project, but I DID see what happened. You are acting like a damned child and should be ashamed of yourself.

Is there some missing context here? Where was the author asked to resolve issues in private? And what 'private' channels would be available to them?

I think they meant to reply to this comment

https://news.ycombinator.com/item?id=49859982#49863097

but commented on the post.

Reply on news.ycombinator.com