It does not send your photos to be indexed on Apple servers.
It's right there in the help text:
> Allow this device to privately match places in your photos with a global index maintained by Apple so you can search by almost any landmark or point of interest.
They are saying that they match your photo against their global index.
They are not saying that they will add your photo to their global index.
Nobody said that except you.