> People talk about their ADHD diagnosis as if it were a fact as permanent about them as their eye color

Because it is, that's a fact. The defining characteristic of ADHD is a lack of dopamine, a physical variation in the brain itself, and that will never go away for somebody who has the condition.