Hacker News Reader

Comment by dmitrygr | Hacker News Reader

Memory is always a scarce resource. However, a big you make the vdso, that amount of memory, multiplied by the number of processes is the amount wasted. In reality, it will be more, because of the required additional page tables to map it at an address range that is not commonly used.

Also, what sort of raving lunatic had a busy loop checking the current process PID? Who allowed such a person access to a compiler? That seems like the bigger problem.

View on HN

I would assume good faith on the part of systemd developers. Afaik they’re as talented as any other top tier group of developers.

Somehow I doubt the code for getpid as a vdso would meaningfully impact the amount of memory used on a running system nor would I expect any meaningful impact to the number of page table entries. Do you have any supporting evidence for your claim otherwise?

Good faith, yes. But even talented people get in strange waters sometimes.

No, libsystemd did this because it’s a library. They went with pthread_at_fork as an alternative to detect when the application code forked, but it’s not without its own set of risks. Of course they could have required the user of the API supply the PID everywhere to avoid this but it’s possible even that wouldn’t solve the problem and it complicates the UI and the UI of the library API is equally important as other technical details - it’s a design tradeoff and judging it as some kind of correctness thing without having a clear picture and insulting the authors out of hand is weird behavior.

I agree with everything you said except that "systemd" and "insulting" don't go together like peanut butter and jelly. Insults seem to be the fuel the project is run on.

>multiplied by the number of processes

Why aren't the pages shared like other dynamic libraries?

If we put the PID into the vDSO, this data page can no longer be shared among different processes (at least not in the same container).

We could use the rseq area for PID and TID.

Because you just asked to put data there that would differ per process?

That doesn't mean that code pages couldn't be shared. The data that differs per process is a single number in this case.

Having said that I agree that it's probably not worth it to put getpid() into vDSO.

A number here, a number there, before you know it, it is a lot.

If we're going to add all sorts of dross to the vdso, like getpid(), who knows what else will end up there?

Reply on news.ycombinator.com