Hacker News Reader

Comment by hipadev23 | Hacker News Reader

[flagged]

This line of comments is toxic but so close to being constructive that I have to comment.

You had an opportunity to help a php newb get better. Your comment even did the work to present the ways to improve the code. It’s all undercut by the tone, however, which really sounds like you’re just shitting on OP.

It would have been easier to just call out ways OP can improve than to shit on their work. Why take the extra effort to be mean?

Thank you for the feedback!

I'm still fairly new to PHP, coming from the .NET/TypeScript world. Unfortunately, it wasn't ChatGPT generated and I'm well aware there's still a lot to learn. I'm always looking for ways to improve, so if you'd like to create a few issues, I'd be more than happy to address them and get the chance to dig deeper into PHP.

You have a great attitude and if you can take the constructive criticism and ignore the rest, you will have a fast growth curve. Nice work and thanks for being courageous enough to post imperfect code. I’ve used php since 2004 and wouldn’t be this brave.

Thank you, I really appreciate it!

It can definitely be daunting putting something out into the wild for people to see, but I've found the constructive criticism (in most cases) that comes with the territory can only help improve whatever it is I'm working. Gotta take it all in stride.

Not being a php-er, it sounds like a good linter/editor support would probably get you a long way - I like using the Jetbrains stuff and they usually have a useful page like https://www.jetbrains.com/help/phpstorm/php-code-quality-too... which walks you through the things that people would nitpick you about.

Absolutely agree, on the todo list. Only using PHPStan/Pint at the moment, though I've looked a bit into the other tools as well and definitely want to get them involved soon to help me as a I go. I've been a loyal JetBrains guy for almost a decade, and I gotta say... PHPStorm is up there with IntelliJ competing for best IDE. I use Rider daily at work, so any chance I get to use familiar tooling in another language feels like it helps level out the learning curve a bit.

Reply on news.ycombinator.com