Yes, ex-smokers should not regret their past smoking habits. There is no point in letting past decisions affect your present emotions.
Like I said, everything must be in moderation. Regrets are effective for reminding us not to repeat the same mistakes. But of course if we regret our mistakes 24/7, it will only depress us and discourage us to do anything.