> what has the war on drugs really ended up accomplishing?

I haven't studied this extensively, and I know that it's widely accepted that the war on drugs was unsuccessful, but I would caution against conflating "it didn't completely solve the problem" with "it had no positive impact at all." As a parent comment mentioned, periods of prohibition are generally associated with lower consumption overall (across both legal and illegal channels).