Apple's plan was to scan only those photos going into iCloud on the client, so that they can send them to the server e2e encrypted. That is strictly better for privacy than scanning them in the cloud, as other providers do.

Of course, they could lie and scan everything, but as others pointed out, they could do that already anyway.