Hacker News Reader

Comment by Double_a_92 | Hacker News Reader

> you can't change a function signature without having to grep your codebase to find all callsited and pray you fixed them all.

I really wonder how people can actually work like that. Is there some overarching methodology like super strict tests with 100% code coverage or so?

View on HN

Tools like https://comby.dev/ help with the refactoring itself, but I'm never really 100% confident.

Regex find and replace across a codebase works fine, especially if the functions aren't overload sets.

If you have a tiny codebase maybe, but if there are a couple million lines, it's likely that a pretty significant number of functions are sharing names.

Those would be the overload sets

The "pray you fixed them all" refers to the fact that you can't really for sure since someone can do

    foo[`asdf{some expression returning string}`](args)

and then good luck catching that call when searching for say `asdf123`. This looks insane when I describe it like that, but you actually see it more often in JS than you'd imagine, and sometimes it may even look justifiable.

Reply on news.ycombinator.com