Amsterdam doesn't seem to be discouraging ordinary tourists; this appears to be targeted exclusively at cruise ships.
Over 5 million tourists visit Amsterdam a year[1]; only a small fraction of that probably come from cruise ships. If banning those ships improves local quality of life and the tourist experience for non-cruise tourists, then it's probably a net win in terms of tax revenues (besides everything else).