Personally, I enjoy the pattern of making the return type a dataclass and make this function a static method on the dataclass, something like `def from_data(self, data: Dict) -> PortfolioRow`.
In 2023, it's rude to return dictionaries. :)
In 2023, it's rude to return dictionaries. :)
Why do you say that?
I think you were partially kidding, but also half serious. What’s the issue with returning dictionaries, and why should we be returning dataclasses instead?
Asking for my own learning.
def some_method(input: Dict[str, int]):
...
vs.
def some_method(input: MyDataClassWithFoo):
...
Regarding rude, yea it was a bit tongue-in-cheek (I would never hold a grudge against somebody for returning a dict).
You should generally define an interface for your function that's as precise as its logic allows for. `Dict` is as good as `Any`: it doesn't tell you very much about what the function internally expects. The sibling comment to mine does a good job going through this.