Have you tried GPT-4? Here's the response I got: https://shareg.pt/Q0ZcWCX
Is it any better? (Your prompt is related to a completely different domain than the one I work in.)
Is it any better? (Your prompt is related to a completely different domain than the one I work in.)
The code has the standard "you can't fit 24 bit or 32 bit unsigned values in an int" bug. I get the feeling this is a common bug. Probably insufficient testing in the hobby implementations used as training data.
My reading of "int length = first4Bytes & 0xFFFFFF" is that it will truncate values incorrectly. I'm pretty sure that "-1 & 0xFFFFFFF != 0xFFFFFFF". It goes (-1 & 0xFFFFFFF) is a long, which is then downcast back to int, truncating it?
commandCode is wrong, GPT-4 is using 28 bits instead of 24.
I _think_ the command code flag decoding is wrong, but it's been a while since I've done bit fiddling. The spec says Request is bit 0, but the code has it in 0x80 - bit 8?
That's much improved from ChatGPT and Bard. The use of the ByteBuffer avoids many of the problems. I've seen that in some GitHub Diameter decoders.
The RFC is here: https://www.ietf.org/rfc/rfc3588.txt - Page 31 for the header.