tx_data[44] = utime>16;
Good catch!I wonder if this would have been flagged with -Wall?
tx_data[44] = utime>16;
Good catch!I wonder if this would have been flagged with -Wall?
Interesting thought now you say that (no warning) - only found it because of seeing the pattern (apropos the article) and from that having a good idea what was causing it (knowing the int was assembled a byte at a time).
If I had a criticism of modern compilers, it's the blizzard of uninteresting warnings ("strncmp takes const char star, did you really mean to pass it unsigned char star") that make people want to not use -Wall.
> ("strncmp takes const char star, did you really mean to pass it unsigned char star")
This warning (with a different function) actually saved my bacon once, pointing me to a very obscure bug in the code.
My practice is to use -Wall and make sure that the code compiles without any warnings at all. Then I don't have a deluge of warnings to wade through.
I recommend asan too, where possible.