There's some truth to this, but environment does make a difference. The problem with this advice is that it seems to imply that moving doesn't make a difference - when the reality is that some people are just better suited to different environments. A nature lover is just going to be happier living somewhere blessed with beautiful nature than in NYC. The challenge of course is distinguishing which problems are external vs internal, and sometimes you need to make the external change to discern the difference.