Yes, for a C function I agree. With just a glance, I can see what this function will do, and what the arguments generally mean. It could be cleaned up a bit (source as a single argument) but this is more about data design, which you might have little control over.