Some people seem to forget that in high-level programming languages, lines of code seldom map 1-to-1 to processor instructions.
Express your actual intent, if your chosen language has a "swap" intrinsic, use it, if not write the swap in a natural and idiomatic way, and let other people do the lifting.