Reasons why it's good:
1. It provides portfolio building opportunities and real-world client experience for new designers
2. It provides hobbyists a good way to try their hand at professional work
3. If the contest holder (client) holds up their end of the bargain and provides all entries with quality feedback, it provides useful practice for designers.
4. I've heard from a large number of designers that participating in design contests led to more visibility for their portfolios and in turn helped them land regular, non-contest employees
5. I can say with confidence that a number of designers on 99designs at least are earning healthy five-figure incomes from contest work
6. Many designers are able to sell losing designs as templates (though contest holders should be careful to put in a stipulation that designers should only be allowed to do that once they remove your name/IP from the design)... or they can repurpose the designs for another contest or client
Why it might be bad:
1. The No-Spec people will say it takes paid opportunities away from designers (I might rebut that it gives more designers the opportunity to compete for work and make a name for themselves -- and that no top tier designer I know is struggling for work)
2. They'll also say that it is unfair for designers -- who are asked to create work with no guarantee that they'll be paid (the rebuttal here: if you don't want to work that way, don't participate -- and as I said above, losing designers can still often make some money from that effort)
Just my (perhaps biased) two cents.
Hey catone, have you added any form of ranking or leader board tied for designers tied to feedback from visitors or clients? One way to counter criticisms would be a ranking or grading system that allows good work to be recognised.
The internet changed the rules on that business and now I pay $10-$20 an image and an infinitely larger range to choose from. But if you were a photographer making a tidy living in 1993, you may not like that scenario.
Some graphic designers are in the same boat now.