Comment by wolverine876 | Hacker News Reader

Comment by wolverine876 | Hacker News Reader

Parent Full thread

It's probably not a configuration you test against (and almost certainly not worth testing against), both an unusual and an old browser used for compatibility with something else.

  Tor Browser 8.5.5
  - built on Firefox 60.9.0 ESR
  NoScript 11.2.11
  - ycombinator.com is 'trusted', which has always
    been sufficient for voting to work

So I'm not filing a bug report, so to speak, but if it helps you track down something useful:

* It happened once before, I think sometime in 2020 (sorry I don't recall more precisely), and it likely would have been in the same browser. I forget what fixed it but it went away eventually. Possibly it was just restarting the browser, which I can try if that will help (but that will lose the current state, of course, and Tor Browser deletes a lot of the current state on a restart; it may create a new profile).

* The top comment on my upvote page is this one from 2 days ago: https://news.ycombinator.com/item?id=29062312

* I don't know the precise times of my comments, of course, but if you see I was commenting then I was very likely voting (though my voting slowed a bit in the last day or two when I noticed they weren't registering).

* I just upvoted your comment at 22:44:07 UTC

I think the problem is that our JS now does this:

  fetch(url);

where it used to do this:

  new Image().src = url;

... and that seems to breaking a few edge cases of older browsers.

Can you try collapsing a comment somewhere and then refreshing the page to see if it stays collapsed? If it doesn't stay collapsed, that's another sign that fetch() calls aren't making it to the server.

> Can you try collapsing a comment somewhere and then refreshing the page to see if it stays collapsed?

I tried a few times on a couple pages, and they don't stay collapsed after refresh.

EDIT: Using another browser on this computer, I just logged into HN, and upvotes and collapsed threads seem to stick. I upvoted your comment (i.e., the parent to this one I'm writing) at 00:27:49 UTC.

This browser (another old and unusual one, but much more recent):

   Brave Version 1.25.72
   - built on: Chromium: 91.0.4472.101

It looks like you managed to upvote https://news.ycombinator.com/item?id=29101929 - did you do anything different to get that to work? e.g. different browser or turn JS off?

Yes, different browser. See my edit in the GP (which seems to have crossed on the wire with your comment).

I reverted the change for voting and collapsing. Does it work now?

Yup, both upvoting and collapsing work. Thanks! Though I wouldn't want to be the edge case that stands in the way of an update. I can workaround it pretty easily.

Another user had emailed to complain of something similar. Where there are two there are probably many, so I think we can leave it this way—it's no big deal. One question though: do 'hide' links on stories work, e.g. on the front page or /newest? I suspect they probably won't, because I didn't revert that part of the change.

> One question though: do 'hide' links on stories work, e.g. on the front page or /newest? I suspect they probably won't, because I didn't revert that part of the change.

I've never used that feature so I don't know what's supposed to happen ...

1. On /newest, under a story, click "hide"

2. Story disappears, stories beneath it are renumbered, an additional story appears at the bottom of the list.

3. Reload page (F5)

4. Hidden story reappears

EDIT: Also, I just noticed that when I upvote a story, the points displayed under the story don't increment until I reload. For all I know it's always been that way, but at the moment, of course, I'm a bit more attentive. Not a problem for me, but maybe useful for you.

Reply on news.ycombinator.com