It seems nice at first - the idea of turning raw energy into things. But the amount of energy required is just ludicrous, going through antimatter intermediary is extremely dangerous, and... there's really no point. It isn't buying you anything.
If you tried to store the amount of energy needed to replicate a kilogram of stuff in some advanced batteries, you'd quickly discover that those batteries now weigh a kilogram more. E=mc^2 works both ways - storing energy adds mass. So, unless you can literally fly through a star and suck it dry as you replicate your tea, replicators won't be reducing weight of a starship. It turns out, matter itself is the ultimate energy storage device.
And then, turning energy into matter just gives you elementary particles. You need more work to assemble that into useful stuff. This is nuclear work, and then chemical work. So why not just ditch the matter/antimatter intermediary, and start from some feedstock that already has the necessary elements, and is optimized to be easy to react into the stuff you want (and then to be recycled from that stuff)?