I don't think anyone is claiming that throwing your money into SPY for a year or even 5 will guarantee returns.
http://archive.nytimes.com/www.nytimes.com/interactive/2011/...
Note that the light red color is actually still indicating a positive real return, this is particularly relevant in the 70s and early 80s when a 2% real return would be a much higher nominal return.
Agreed that some people expect returns for time horizons as short as 10 years though, which is clearly a mistake.
http://blog.nawaz.org/posts/2015/Dec/pay-down-mortgage-or-in...
Must be some differences in the data they have vs what I could find. I did include inflation and dividends, but not taxes - wondering if that brought it to the negative.