Rooftop solar still have 5+ years ROI. Recently utilities changed billing plans to make it even less attractive.
Why is that a problem? Most people take multiples of that time just to pay off their mortgage. Maybe if you are house flipping, but even then this tends to increase their value.
That said, it does make sense if you do plan to stay for 10+ years I think. As new houses get built, hopefully with requirements for solar, the housing stock will eventually all be upgraded to include some form of solar generation. I would expect the price to further come down and the majority of homes in the 1st world to have residential solar of some form within the next 30 years.
https://en.wikipedia.org/wiki/Return_on_investment
Payback period is.