> You would think Apple as a hardware company would open up software to increase hardware sales, but instead it seems to try to control everything so it is fighting a battle on multiple fronts.

Purely on the business perspective, Apple has seen tremendous benefit with their locked ecosystem and vertical integration. Bringing that strategy to the PC market was bound to happen and it's likely going to work extraordinarily well for their share holders if performance/productivity benefits (from Apple Silicon) at low-mid end forces traditional PC consumers to Mac.

On the consumer perspective, Would we accept a $1000 PC couple of years back with no means to install other Operating System (Officially), Only 3-5 years of updates(if lucky), Use only manufacturer approved apps, Repair only at their approved centres?

Then why did we accept it to be a norm for >$1000 smartphones?

We made them smell money with our consumer decisions to trade 'freedom in computation' in smartphones and it's now coming to haunt us with personal computers. The line between Smartphones and PCs have been blurred with Apple Silicon, Google will do it with their Chromebooks(which was already happening even without their custom silicon [Update cycle, Locked boot-loaders etc.]) and Microsoft with their Surface line up.