Hacker News Reader

Comment by daleharvey | Hacker News Reader

    Problem at line 1 character 6: Move 'var' declarations to the top of the function.

I do prefer having all my vars at the top of the function, loop vars are an exception though.

I think Crockford is right about that error.

Declaration of variables in the loop could lead to this type of error:

(All of the 4 <li> will do alert('4') when clicked, when the programmer expects alert('1'), alert('2'), etc.)

If the variable had been declared at the top, that error probably would not happen.

That error would have happened despite if the var was declared at the top or in the loop

    addEventListener("stuff", function() {
        return function(index) {
            alert(index);
        }
    }(i);

is the fix, either way

Yeah. I meant that the mistake is less likely to have been made in the first place.