Hacker News Reader

Comment by vimslayer | Hacker News Reader

Your implementation is missing features like capture-based substitions

     // Remove repeated characters
     'foobar'.replace(/(.)\1+/g, '$1')
     "fobar"

and overriding behaviour with Symbol.replace

View on HN

You're right, my implementation was not a drop-in replacement for replace. How about this?

    String.prototype.replaceAll = function (n, sub) {
      let t, f = "g";
      if (n instanceof RegExp) {
        t = n.source;
        f = n.flags;
        if (!f.includes("g"))
          f += "g";
      } else {
        t = RegExp.escape(n);
      }
      let r = new RegExp(t, f);
      return this.replace(r, sub || "");
    }

Reply on news.ycombinator.com