A friend of mine tells me that one of his biggest regrets from the past handful of years is not having applied for and received citizenship when President Obama was president. He has a misdemeanor (for something that almost every US citizen would consider trivial) from when he was a teenager but because of when it happened and what it is, naturalizing would require a waiver from USCIS in order to proceed (and to not be deported). President Obama's USCIS granted waivers for conduct so many years back almost as a matter of course. President Trump's USCIS--according to the two immigration lawyers my friend has consulted--has not only stopped granting the waivers, they refer applicants for the waivers instead to deportation proceedings. There's no one to advocate for people like him to be able to remain because he is a convicted criminal, even just of a minor offence, so he's been told to keep his head down and hope nobody investigates the dusty files.
But, assuming you are "clean," there are people to advocate for you so applying for citizenship should be a safe bet and would get you the guarantee of remaining in and traveling to and from the US for the rest of your life. If you intend to live here for the foreseeable future, I'd recommend giving it a go lest this administration decide to start trying to arbitrarily yank GCs.