Nice work!
As a WebRTC implementer (both native and in Chrome), I applaud the work!
But I can only notice quite a bit of mismatch between your APIs and the current spec. Do you plan on updating your implementation to match it?
But I can only notice quite a bit of mismatch between your APIs and the current spec. Do you plan on updating your implementation to match it?
I've had some great interactions with the Mozilla crowd (hey Lennart, hey Nils) - looking forward to more of the same!
For example, RTCRtpSender.getParameters is missing and the setParameters seems to be missing (unless that's the send function). And as far as I can tell, you are not supposed to call setParameters without getParameters first, so that's not spec compliant ;)
And of course, the sendEncodings property of the init parameters in addTransceiver is missing. It is required to setup simulcast (and later SVC when we standardize it).
https://github.com/jlaine/aiortc/issues/76
aiortc's RTCPeerConnection indeed uses RTCRtpSender.send to apply parameters. This is directly inspired by ORTC:
If you want to implement ORTC, fine, but you should probably do it in another package and make sure you don't expose fields in WebRTC that aren't part of the standard. Some fields (like the SSRC field) is not exposed for good reasons.