Ok that's better than if only currently-residing people were allowed to vote. The argument stands for Catalans living elsewhere in Spain.

But I grant that "you're allowed to vote if you can vote in the General elections as a resident of one of the four Catalan provinces" is probably as fair as one can practically get when designing this.