(Putting the Earth-science thing aside for the moment.) It really is a mostly non-partisan divide, here.
NASA has its own problems. A culture of risk averseness that is incompatible with new approaches like reusable rockets (although NASA will use them if they're proven by others). A culture of safety-uber-alles which is even more incompatible with expanding the capability of human space exploration in particular.
But for all that, NASA still accomplishes great things. NASA has been critical for the success of SpaceX (around 2008 in particular) and even has helped Blue Origin considerably. NASA has completed the International Space Station (the largest spacecraft ever built by far) and kept it inhabited since 2000. No one under the age of 20 remembers a time when there wasn't at least a couple people aboard the Space Station. This program has built up a level of experience with long-term human spaceflight that, in aggregate, exceeds all other such programs. We have experience manufacturing in space and leveraging ISS for launching commercial satellites (Planet.com in particular), helping pave the way for the current wave of smallsat launchers.
There are now half a dozen active satellites (half from NASA, but all with assistance from NASA) in orbit around Mars, two active on its surface, plus a probe around dwarf planet Ceres, Jupiter, Saturn, and another probe, New Horizons, which has visited Pluto for the first time and is now on its way to other destinations deeper in the solar system. This is all just scratching the surface of NASA's accomplishments in this time. (And next year are slated the launch of two commercial crew vehicles that NASA has been funding, SpaceX's Dragon 2 and Boeing's Starliner.)
See https://arstechnica.com/science/2010/04/obama-resuscitates-o... and https://arstechnica.com/science/2009/10/nasa-panel-argues-fo...
Quote: "The committee has concluded that NASA now has plans that don't reflect any sort of budgetary reality". This is back in 2010.
More recommended reading: https://en.wikipedia.org/wiki/Space_Launch_System#Criticism
The problem is the public lost interest in the moon. It's a big dusty rock with nothing much to recommend the billions we were spending to go there.
Btw for 2017 it's 773.5 billion USD.
You don't need an official space weapons program to be able to drop heavy things from orbit. Nor do you need a fancy anti-satellite ballistics system when you can have one of your many astronauts sidle over and hit it with a hammer.
"Amateurs talk about tactics, but professionals study logistics." - Gen. Robert H. Barrow, USMC
And exactly this thing seems to be the major problem with essentially every space-related weapons platform other than ICBMs. Simply almost every such proposed system uses some expendable ammunition that is significantly more expensive to deploy or even just manufacture than what it is supposed to destroy.
Then we can have ourselves a Pluto colony.
I agree with the slash the defense budget part, but NASA doesn't need 300B/y (and would have a hard time spending it even). They need ~30B/y (i.e. double their existing outlay) to do SLS and continue existing operations, and it needs to be in a lockbox of some kind such that future political swings require a huge amount of horsepower to disrupt it (like a congressional super majority vote).
Smoke alarms alone have saved hundreds of thousands of lives.
https://www.nasa.gov/offices/ipp/home/mythbuster/myth_barcod...
edit: actually pretty much none of the things you listed were invented by NASA, several predate its existence.
I don't think they have got anything interesting done in manned spaceflight lately.
I think this is pretty well hopeless at the moment. Major NASA projects have a timeline and cost operating on a 10+ year scale, but their budget changes annually and their priorities change with presidential election.
Really the only way I can see things improving is if a president managed to stake out a task that couldn't be taken away from them by the next one. I'm not sure how you'd achieve that, either - budget it all up front and tell them to buy gold bars with the money they'll need later?
For some reason the unmanned missions are managed much better. I do a lot of reading about them and all the decisions, trade offs and plans seem to be the result of careful and realistic planning.
I think it's largely because they don't have so much safety-related red tape. Loosing a robot is not nearly as big of a deal as loosing a human.