Hacker News Reader

Comment by mnarayan01 | Hacker News Reader

Looks like a nice library, though using a default of `*` for Origin seems like an invitation for people to shoot themselves in the foot.

View on HN

Yea, that's totally true. I would recommend using an origin property to be used every time an instance of the Library is created. Please refer: https://github.com/wingify/across-tabs#usage

Then don't have a default that works without doing so. Really, defaults like this lead to "works, ship it" and totally unnecessary cases of vulnerable software.

Second this. A lot of developers will just drop it in without reading the caveats. Just make the origin a mandatory parameter.

Does that mean, the library should not act when an origin is not specified and throw some kinda message in the console?

Yes, a required argument. It's not uncommon. Think API keys.

Reminds me mongodb being open/unprotected by default, that turned out well...

Don't use unsafe defaults ffs, that's how things get exploited.

Does that mean, the library should not act when an origin is not specified and throw some kinda message in the console?

How can it be enforced? Any suggestions?

Users can also make it a bit more complicated while using `*` to get hacked by accepting responses which match some kinda pattern(it's not bullet-proof though) and simply discarding others.

Put the wildcard functionality behind a setter with a long name and make the default the current domain?

Put it behind a setter with "doNotUseOrYouWillBeFired" in the function name.

https://github.com/facebook/react/blob/80bff5397bf854750dbe7...

Reply on news.ycombinator.com