Absolutely.
Further, I would consider Linus's one-liner 'indirect=...' to be 'clever' code.
If I were reviewing it, I would want it expanded into more obvious code as it requires too much cognitive overhead to parse.
Further, I would consider Linus's one-liner 'indirect=...' to be 'clever' code.
If I were reviewing it, I would want it expanded into more obvious code as it requires too much cognitive overhead to parse.
I don't find the pointer syntax that difficult to reason with.
How would you expand the code?
People will and are arguing that "it is kernel code, it should be complicated" but I really think this is backwards. Because it is low level and debugging is really cognitively intense and difficult at this level the code should be even clearer and easier to understand.
This code is inherently too complex. it should be simplified