I agree that the support time was too short, but this is not the complete picture. OS X Lion was the last version that runs on the 2008 MacBook and received security updates until October 2014, so the model was supported for 6 years.
In the end, her LCD started to short out anyway -- a common issue with Macbooks of that era -- so we got her a basic Toshiba laptop for about 1/2 the price of a Mac. It's still humming along nicely and I just dropped an SSD in it to give it a huge speed bump.
You are doing it wrong ;). The resale value of MacBooks is very high. My wife usually gets my current MacBook after 1.5 years and we sell her old MacBook. We usually get 600-700 Euro. 400 Euro for using a MacBook for three years in total is not bad...
The resale value for Windows laptops is typically bad. There is a company across the street where they sell 3-4 year old ThinkPads for 300 Euro.
Windows vs Mac resale value plays a lot into the way Windows folks use their laptops. The reason is that they generally use a given laptop until they no longer need it. My girlfriend's laptop will be 5 years old this year and was purchased for about the same amount of money it cost you to use your Macbook for 3 years. I spent another ~US$100 to upgrade to an SSD recently which will give it quite a bit more life. And it can be upgraded to Windows 10 for free if we want to at some point. Granted, it's only used for web browsing, office suite stuff, watching videos, recording and editing voice-over work etc, so it doesn't need to be the latest and greatest. So, it's really more a different use case.
Your typical pattern of buy and sell is kind of fascinating to me as a Windows user, but makes complete sense given the comparable markets and models. The wider array of Windows laptop choices in different budgets accounts for the lower resale value of higher end Windows laptops. Most users are fine spending $400 or less on a Windows laptop for the basic browsing, email, photos, videos, etc needs. High end Windows laptop users want a new machine, not a used one. So, there's not much interest in $500 used Windows laptops... they don't serve either market segment well. In Mac-land, there is no $400-500 Mac laptop option, so anyone with only that budget has to look at used models. Thus, the demand keeps the cost for a used Macbook high compared to Windows laptops.
In the end, I think we're both doing it right for our needs :)
Either way getting 5+ years out a laptop is outstanding. I went through a few Sony Vaios in that amount of time during their hayday plus a brand new computer that had the monitor go out completely. Plus I was stuck on windows which is a big pain point for me.
Looking forward to replacing the '11 MBP once another refresh happens this year.
For most people who do a bit of emailing, some light www browsing, a bit of word processing and spreadsheeting, some messaging, and some very light gaming (solitaire): it's profoundly depressing that the needs of the bloated OS and the modern WWW[1] drive the need for ridiculous amounts of RAM and processor power.
[1] Not talking about app delivery here, but about a newspaper website delivering mostly text and images with a bit of CSS, which they manage to turn into megabytes of text. Like, I have no idea how a recipee for daal turns into 5 megabytes.
Those old plastic MacBooks (the original 2006 MacBook 1,1 and newer) can all run Windows 10 via Boot Camp. Installing Windows 10 will give those machines a new lease on life - various apps like Kindle & Chrome 32-bit are no longer supported / updated on those old Macs, but they'll run perfectly fine under Windows 10.
Some of it ages better than others.