> Did someone on your team do something differently than how you would do it? Reprimand them! They might tell you that it works just fine, and that their way is just as good. But it’s not your way, so it’s not right.
An important question to me: what is a reasonable level of code-style guidelines for a manager / lead code-reviewer to enforce? I was in a position where all my code had to be reviewed and approved by this guy before it would be merged. It felt like I had to read his mind in order to get it correct and get it merged. I would spend as much time tweaking things stylistically to appease him as writing actual code.
So how do you determine what's an appropriate level of strictness and what isn't? Obviously a consistent code-style in a codebase helps make it more readable, yet obviously it's also possible to be too pedantic. I have trouble knowing where the line is. In my case, I don't know if the guy reviewing my code was the problem, or if I was the problem for being annoyed by it.