HNHacker News
TopNewBestAskShowJobs

rikatee

542 karma · joined November 24, 2014

submissionscomments
rikatee··on Show HN: A Django code review bot for GitHub pull requests
Nope, all 100% pure custom code.

The closest to existing tools are: https://github.com/lamby/django-lint/ https://github.com/PyCQA/pylint-django

but- you have to set those up yourself in a CI and update them manually and not have the cool feature like PR integration, "fix it for me" (you would have to fix it yourself like a barbarian), the slick companion website with the beautiful blue progress bar :)

With Django Doctor you just click "install on GitHub" and boom, you get updates at no effort, and if you like the suggestion Django Doctor makes you just click commit

rikatee··on Show HN: A Django code review bot for GitHub pull requests
Not to nitpick, but restyled and Django Doctor do different things in different ways, so I don't think it's and OR
rikatee··on Show HN: A Django code review bot for GitHub pull requests
Our business model will soon become clear: oranisations will pay. Individuals not. Currently still ironing out things and seeking feedback so at the moment free to all so I can get maximum feedback :)

btw, we dont actually have any of the user's data. We literally do not have a user database. All we have is a link to a public repo. It currently works only on public repos. So no danger of Django Doctor doing anything odd with your code because the code is already public. No risk of Django Doctor doing anything strange with your personal data because we don't have any :)

rikatee··on Show HN: A Django code review bot for GitHub pull requests
Blocking the build works well for things that are boolean "correct" or "not correct", but some things are not are just "food for thought". Django doctor points out when something looks like it can be improved, but that's ultimately up to the dev to take the advice. It's "have you thought of..." rather than "you must do this".

With the advantage that if the dev likes the advice, all they need to do is click "commit"

rikatee··on Show HN: A Django code review bot for GitHub pull requests
I've been in a few organization with hundreds of repos. It can be a pain to upgrade libraries. In this context, with SaaS you don't need to.

But yes, SaaS is not a silver bullet. If you like convenience and getting updates, bug fixes, and quick set up with no overhead then it's for you. If you want to run things yourself then understandable have a great day :)

rikatee··on Show HN: A Django code review bot for GitHub pull requests
Unfortunately not. It's aimed at SaaS so users gain some convenience but lose a bit of other things :)
rikatee··on Show HN: A Django code review bot for GitHub pull requests
Thanks for the feedback, and glad you found it useful :)
rikatee··on Show HN: A Django code review bot for GitHub pull requests
Perhaps I need to clarify "auto fix" - the dev still needs to click "commit" on the suggestion. Given a PR with 3 Django Doctor suggestions, 2 could be ignored and only 1 committed by the dev if they choose.
rikatee··on Show HN: A Django code review bot for GitHub pull requests
Bear in the comments are "food for thought" and aren't aimed at blocking merge. In the review you can pick which suggestions you want and can ignore the stuff that does not add value to you.

Soon we will be adding a config file so you can mute the things that ar vexatious

rikatee··on Show HN: A Django code review bot for GitHub pull requests
Django Doctor suggests code improvements in your pull requests, so you get better code with no extra effort.

What will Django Doctor say about your code? Check now for free at https://django.doctor

If you dig this then you may like to install the bot on your GitHub pull requests

https://github.com/marketplace/django-doctor/

rikatee··on Django GitHub PR bot that suggest the fix
I made this!

Django Doctor scans your PR for Django anti-patterns and comments the fix in the PR. You click "approve" to commit the fix for low effort code improvement.

Install the github bot at: https:// github.com/marketplace/django-doctor/

← PreviousPage 3 of 3