None of the things you are talking about were suggested or even mentioned by the parent comment. No one said anything about cast systems or eugenics. You are beating up a straw man.
It's pretty well supported that intelligence is heritable and greatly determined by genetics. But so are a huge number of other traits, like executive functioning and attention span, which also correlate with success.
And we don't need to be constrained by genetics either, even if a trait is environmental, parents still have a huge amount of influence over it. From education to work ethic, your upbringing has a huge amount of influence over you, and it's something you basically pass down to your children just like genetics.
>Jonas Salk had three children, but anyone who claimed "his children are his greatest accomplishment" would be laughed at.
This is a counterexample to the claims you are defending, that you can't be successful/change the world, and have a family.
Regardless, that's great if you are Jonas Salk. Sacrifice your personal life to save the world. It's certainly a noble thing to attempt.
But most likely you aren't Jonas Salk. The average person is not going to impact the world anywhere near the level of Jonas Salk, no matter what career they are in or how hard they try. Even Salk, if he hadn't been at the right place at the right time, working on the right problem, would not have been remembered today.
So yes it's not surprising that his children aren't known for anything. Even if they had been exact clones of him, they were born at the wrong time to cure polio. But if they are like him, they have the same probability of doing great things as he did when he started. So if your goal is to maximize the probability of doing great things, having children isn't a horrible option.