Extracting the SuperFish certificate
blog.erratasec.com
blog.erratasec.com
Maybe the cost of a security audit required as a consequence of this issue might qualify - I don't know. But there would have to be actual costs involved.
Ok, googled it, wait for it... "As I understand it".
Whew!
Incidentally, I didn't understand this one, but I don't blame OP (oops, I mean 'original poster') for misunderstanding the linguistic norms of HN (hacker news).
Similarly, compare "(c) 2015 philh" to "this post is copyrighted by philh, as of 2015".
So, basically what you're saying is that I can secretly take nude photos of you (when you're not in a public place), and "enjoy" them (in whichever manner) but not share them with the public, and you can't sue me unless you can demonstrate my actions actually costed you money?
However, depending on your jurisdiction that may be a crime. In that case, I or the state might be able to prosecute you under criminal law. I don't generally understand that to be within the meaning of "sue" though. And, again in general, criminal conviction leads mainly to punishment rather than reparations to the victims.
Oh, and exceptionally, if I'm your "model" then without me signing an appropriate release I own copyright on your photos, so I may be able to sue you for losses (probably to the value of you buying an equivalent market-rate DVD or something).
You sure about that? AFAIK the copyright is with the creator, i.e. the photographer. Model release is required on for privacy purposes, not for copyright.
1.http://www.theguardian.com/technology/2014/aug/22/monkey-bus...
I'm no lawyer, but as I understand it, you sue people under civil law for some kind of compensation - for financial loss, loss of reputation, psychological consequences, etc. Your voyeur example would hopefully fall under criminal law, which deals with the things society considers morally wrong. But a criminal trial would be prosecuted by the government, not by you suing.
Those damages may be minor -- you don't have to have killed anyone -- but they have to exist.
If, in your example, GM only installed the worn out brakes on that one car, and the worn-out brakes never caused any damages, then no, GM cannot be sued for it.
Note that "I had to pay a mechanic to replace the brakes" is damages.
I am not a lawyer, this is not legal advice, I may be wrong, etc.
But in this case, there is good precedence for claim of damages. People has used time it have taken a engineer to investigate, clean, and fix a computer system after a computer intrusion. Even a few hours work will result in several thousands, much more than the laptop itself is worth.
[1] http://tweakers.net/nieuws/101472/lenovo-overtreedt-wet-met-... (lang:nl)
Lenovo didn't just sell something with broken security. It purposely broke the security, and profited from it.
Did they inform their customers in advertisements, in the stores, or in any way that sold devices was being used by Lenovo after sale? Were there a meeting of minds where customers agreed to have their traffic MiTM and have advertisement of Lenovo choice on their device in return for fair compensation? That could have made it legal, but as it stand, no aspects of consumer protection laws, advertisement laws, contract laws, computer crime laws, or data protection laws seemed to have be followed.
They secretly snuck into peoples private property, used a backdoor, and earned profits doing so. They didn't tell anyone for obvious reasons. Had it been a one-man company doing this, then that person would be facing jail time.
In the Lenovo case, probably not. But in the case of an employer-provided system and network intended for business purposes which performs SSL interception for security and data leak prevention? I think it can clearly be considered reasonable for the company to do that, and the user's expectation of privacy is significantly different. I do feel it's important that Acceptable Use Policies, Employee handbooks, etc. disclose the activity though.
a) selling capability to advertise to you, without your real consent, and
b) when the do it, the implementation is so horribly broken that it exposes end users to be exploited by just about anyone.
I see little malice, I see a lot of incompetence and outright, unforgivable stupidity. This opens door to the malice of others.
The offence of unauthorised access requires proof of two mens rea elements, (see section 4 CMA):
(1) there must be knowledge that the intended access was unauthorised; and
(2) there must have been an intention to obtain information about a program or data held in a computer - section 1(2) CMA.
[0] http://www.cps.gov.uk/legal/a_to_c/computer_misuse_act_1990/[1] http://en.wikipedia.org/wiki/Donoghue_v_Stevenson "it was reasonably foreseeable that failure to ensure the product's safety would lead to harm of consumers."
Choice quote: The settlement requires HTC America to develop and release software patches to fix vulnerabilities found in millions of HTC devices. In addition, the settlement requires HTC America to establish a comprehensive security program designed to address security risks during the development of HTC devices and to undergo independent security assessments every other year for the next 20 years.
[0] http://twitter.com/JustinBrookman/status/568466666771910657
Here's a screenshot of what their MitM proxy provides back to the browser for a compromised connection to Bank of America:
https://defaultstore.com/four.png
Note that my MitM proxy cert is one gen'd with OpenSSL and is not the Superfish private! While it's cool that the private can be extracted, given the failure of the Superfish software to properly validate the public in the SSL/TLS handshake, the Superfish private isn't something a bad guy needs to get in the middle of encrypted traffic.
Lenovo which actually facilitated breaking ssl security on all of their customer computers is going to get away scot-free?
"WASHINGTON-The Canadian government has delivered a scathing response to a $500 million lawsuit from the American pharmaceutical industry, dissecting the intellectual-property practices of the company that launched the case.
.. Eli Lilly had filed for 12 separate patents between 1992 and 2004 claiming it could treat psoriasis, stuttering, incontinence, hot flashes, anxiety, learning disabilities, tic disorders and, finally, ADHD.
.. “Canadian law does not grant patents for almost-inventions,” said the submission. “Even if the applicant’s speculation at the time of filing is later confirmed.”
.. The Canadian government shrugged off its appearance as the only G7 country on last year’s U.S. Trade Representative watchlist. It described the list as a bunch of allegations from U.S. companies, published by the U.S. government."
That of course should read "If the personnel at a major multinational bank ..." - it's those who created and authorised the scheme, real actual people, that are getting off. It's not a vacuous idea of a corporation, the corporation didn't commit the crimes, people did.
Other than that, yes, powerful millionaires don't get put in prison for scamming the demos. Prison is only for the proles it seems.
Similarly, if you or I were to install a MITM proxy that intercepted ssl traffic on someone else's laptop we would see the full weight of the criminal justice system rain down on us. But when a big company does it systematically they will almost certainly escape virtually scott free.
Thanks for making HTTPS non-mandatory in HTTP/2, IETF!!
You're shitting me!?! Who, specifically, do we have to blame for that?
http://lists.w3.org/Archives/Public/ietf-http-wg/2013OctDec/...
>To be clear - we will still define how to use HTTP/2.0 with http:// URIs, because in some use cases, an implementer may make an informed choice to use the protocol without encryption. However, for the common case -- browsing the open Web -- you'll need to use https:// URIs and if you want to use the newest version of HTTP.
Someone explain to me when "an informed choice" would ever come to the conclusion of, "Encryption? Not Necessary!"
I've been informed that encrypted web traffic costs money for the certificate and for additional server hardware. Thus I made the informed choice to use HTTP/2.0 without encryption.
1.) You can make and self sign your own cert. As another poster pointed out, there's also distributed solutions.
2.) When we let standards that are going to be in-place for at least a decade be manipulated by the hardware costs at their inception, it's a bad standard.
Now if you provide authentication by other means, and confidentiality of the traffic not important, plain text protocols make sense because it enables caching proxy.
Typical use case: software updates distributed as signed packages. The information isn't very confidential, and using plain HTTP enables the usage of a caching local proxy.
Authentication of the server is not sufficient, you also have to authenticate every message as having a valid checksum and signature.
>Typical use case: software updates distributed as signed packages
This is a specific use-case because the package checksums are verified before any of the code is executed (unlike injected javascript to webpages). Also the checksum is usually obtained from the package server, so if SSL is broken the checksum can be spoofed as well.
Could you elaborate on why that is the case? Do you perhaps mean cryptography rather than encryption?
That's true the poster said authentication of the server, if you sign every message cryptographically, you'll be able to detect message tampering. I should edit that.
It's 2015 and we have quad-core processors in phones that are faster than my laptop. What reason can anyone possibly have to not at least strive to encrypt everything? When is it advantageous to not encrypt?
If you have Superfish and want to validate this behavior for yourself, you can visit https://defaultstore.com/ and watch it accept an expired cert. Given this situation the Chrome team and others should without a doubt treat the cert as revoked.
It's likely a lot of people are still running that software. I bought a Lenovo Yoga 2 11 today and it had Superfish installed by default and all my connections are MitM'd on that machine.
UPDATE: if the cert is revoked, it will likely leave a lot of people unable to browse the web. It would be nice if the revocation process in Chrome could provide users with instructions on how to remove the software.
http://www.komodia.com/ad-injection-sdk/
Edit: spelling
Actively remove global proxy injected JS by
either removing the JS from HTML or blocking
the requests to the ad server.
So if someone else injects JS, they remove it before injecting their own."... allows you to get/modify/inject all SSL traffic decrypted and without any warning messages to the user."
Interestingly that site got DDOS'd.
>I could just use the file super.txt as my dictionary!
I discovered it when I'be bought Lenovo Yoga2 Pro in December, and I could not login to my site that is using SSL cert authentication. Google than recommended me to remove SuperFish...
[1]: http://security.stackexchange.com/questions/29988/what-is-ce...
An over-simplified example: if Alice (A), a client with web browser on a compromised computer, wants to access the BigCorp website (B) she sends a challenge, such as a random string, to B, and B sends back the challenge encrypted with the BigCorp SSL certificate. Alice's browser verifies that the signature corresponds to a valid certificate, which it does because BigCorp's certificate is legitimate and signed by a legitimate CA, and then Alice's web browser and the web server negotiate a session key to use for SSL.
If we introduce an attacker, Eve (E), to this, who has the key to a trusted certificate on Alice's machine, Eve can intercept Alice's original challenge and send back an answer to that using the trusted certificate, which Alice thinks is genuine because the certificate is valid in her browser. This is where certificate pinning helps, since if Alice has visited the site before, the certificate does not match and she gets an error. After the negotiation, Eve then has a session key to both A and B, and any data that A sends, Eve decrypts and re-encrypts with the session key for B, passing it seamlessly onto B, and vice versa for traffic going the other way.
SSL client certificates break for a MITM attack for a different reason. When Alice is using an SSL client certificate to authenticate herself, she has her own certificate on her machine which she knows the private key to (it can even be self-signed). The web server knows Alice's public key (stored like a password hash in a database), and can therefore perform a similar challenge for Alice. When Eve intercepts this challenge, she cannot send a valid response back to the server, as the only valid key for Alice's account is stored on Alice's computer. Therefore, sites that let you sign in with an SSL client certificate often just stop working when you are being MITM'd.
[1] http://www.symantec.com/connect/blogs/client-certificates-vs...
I presented on the topic at Blackhat Europe a few years back, where I disclosed several certificate validation flaws in Cisco Ironport. I understand there's legitimate reasons for enterprises to want to decrypt and inspect TLS connections, but it's not without it's risks and downsides.
If you're curious about my past work, see: http://www.secureworks.com/cyber-threat-intelligence/threats... http://media.blackhat.com/bh-eu-12/Jarmoc/bh-eu-12-Jarmoc-SS...
Security cuts both ways. I think the most important point is that the user should be in control of the traffic, which means knowing whether or not interception is being used.
Your view seems to reflect a similar nuance as my own. Administrators need to weigh the risks and benefits as it relates to their own environment, and users should at least be aware that such monitoring is taking place. Beyond that, there's some technical challenges, but I see the bigger issues as political and expectation vs. reality alignment.
There's also a video of my talk online, which I'd honestly forgotten about. Maybe someone will find it interesting; https://www.youtube.com/watch?v=7TNdHzwTNdM
And your 'monolithic' is a symptom of architecture, that is either outdated ("not hipster") or just bad. But that does not mean that someone can't build hipster and good network level security. I guess, Google does not buy that off the shelf.
Don't you have to intercept/reject TLS to make that workable? Otherwise the user (or malware) can upload or download anything and all you see at the network level is a destination IP address. If a user has admin rights (which is common in corporate environments) then they can install software which can mimic a browser using HTTPS.
At the network level it is difficult to identify what program generated a request and which user was running that program. I am very sceptical of the heuristic approaches that try and solve this problem (Palo Alto App-ID for example) that display quite shocking emergent properties.
Surely it is technically preferable to track network requests within the OS and browser where you can actually get at information reliably without any hocus pocus. If a user can avoid it by just "shutting it down" then they can also remove the AV, connect to a proxy and spend the afternoon uploading client lists to a porn site.
The whole X.509 infrastructure is based on trust. You have to trust your certificate store, the certificates, the network and its components and CAs need to trust those who request certificates. If you have to use a network that uses a proxy, you have to trust it aswell. If you do not, then just do not use it or at least don't do your online banking over that network (or use a VPN if allowed (sigh)). So a good network security deployment is not only well maintained, but also transparent to its users on what it does. The user must have a choice on whether a network is trustworthy or not.
The problem with SuperFish is that it shipped not only the root certificate, but the private key to sign new certificates on the fly. And the user was not informed about it and not given a choice. This is the problem here.
Most clients I worked for provided me with a separate network for unfiltered internet access (guest networks) in which I used a VPN to a network which I trusted. I was given a choice.
Edit: A thing that bugs me often is when I see a network proxy that does not use TLS for the proxy connections. Unfortunately that is happening in the majority of networks, I see. And that affects my trust, so I rather avoid accessing certain services when I cannot have my VPN.
An example for why wildcard certificates are bad is Microsoft. A couple of years ago, they had problems with subdomains which delivered malicious code through hijacked web pages that were hosted on those domains. Microsoft used a wildcard certificate...
Here the problem is not that the proxy would be trying to insert advertisements to the content. Just changing IP addresses within AJAX content may break functionality in nasty ways. For instance, so that things work with some browser and not another one, or reuiqre a particular engine setting in MSIE11, or some such. There is no problem in the service itself, but the service gets the blame because people can't think that a Cisco product in between might be the cause.
I've been working my entire career for large companies. I've experienced many solutions and I cannot remember one technical problem that was caused by network security, other than "InsertYourSocialNetworkOrBinary was denied by SecurityRuleXYZ". At several companies I had to sign a paper that informed me about the security implications and my duties when using the companie's Internet/network access.
HTTPS man-in-the-middle proxying is one particular scourge that causes weird things - the problem reports being of the kind that in a completely legitimate and intended use case, "Chrome works, MSIE does not".
"Barak Weichselbaum founded Komodia, Inc. in 2000, following his military service as a programmer in the IDF’s Intelligence Core." https://twitter.com/idfspokesperson
As another poster says, this likely means nothing as all Israelis are forced to go through a military brainwashing program.
No way out for a male.
Or do they leave the page intact if the page certificate is not legit?
http://www.komodia.com/wiki/index.php?title=SSL_Digestor#Cer...
We discovered this a few months ago after customers with lenovo laptops were complaining that our site wasn't working for them.
<meta name="superfish" content="nofish">
and everything is all right ;-)
EDIT: Why has this been downvoted twice? It's absolutely correct.
It's a strange day when you post something unambiguously true to HN and it gets summarily downvoted.
The only part that isn't unambiguously true is that "most users without adblock are used to such behavior already." But I stand by that phrase, because "most users" are people who understand almost nothing about about computers.
Remember, downvotes are reserved for trolls and people you disagree with, not something which you think is "maybe untrue but I don't know whether it's true." I've complained in the past about having to write epic edits because people don't follow this so I have to explain myself further.
Maybe you want more explanation about how precisely the above MITM would work? Here's how: The page loads. This completes normally, and the user doesn't see anything differently. In the meantime, Superfish reads the network traffic that has loaded. It also has injected some javascript in order to reserve a spot on the page to display ads. This would be a big blank space where the ads go after they load.
Now the network traffic is sent off to China or wherever. It's analyzed on a server, then the server sends back commands to Superfish about what to do, like "Display ad 91234128 at X,Y spot on the webpage."
The total roundtrip time would be no more than a few seconds. China isn't the moon. Half the speed of light is fast.
The page would load normally, then Superfish would be shipped off to China, then it would receive a command back from China about what to do.
I have no idea why you're chasing this thing. The gist of nailer's original post was asking why the private key was accessible. Whether the local proxy talked to a box in China or not seems completely irrelevant.
This subthread is about private key distribution. It's really poor form for you to react to being downvoted (as legitimately wrong) by lengthening your comment by a factor of 5 and lecturing people about downvotes.
I disagree that it's poor form to react to downvotes when they're wholly unjustified. Maybe I did a bad job explaining myself. In that case, I should explain myself better. That's a positive thing, not a negative. Reddit has this stupid trope like "Complaining about downvotes? That's a paddlin'." Which if you think about it just a self-reinforcing culture of bandwagoning. But I imagine that this is now entirely offtopic and boring, so let's focus on the tech.
You should also read the HN guidelines before explaining downvote etiquette to me, because they will surprise you, apparently.
Who cares if someone thought that the proxy was going to work like X, but it turned out to work like Y? What matters is that if it can work like Z, then Z should be pointed out, especially if it enables some interesting aspect that people previously hadn't noticed. Anyway, you've successfully killed the fun of HN for me for the day, so see you later.
You really need to unplug for a bit. I'm dead serious.
EDIT: Yeah, I was being an idiot. Thanks for the reality check.
However these days insecure images/video etc in a page served over HTTPS will trigger mixed content warnings in most browsers.
Someone should sue to see these contracts open in the public.
http://www.komodia.com/wiki/index.php/Komodia%27s_Redirector...
(Down near the bottom, "sslpsd - To the password of the root CA (it's mandatory).")
http://www.komodia.com/ad-injection-sdk/
But if you look at what Komodia says on that page regarding anti-virus:
"The SDK has anti virus capabilities and each compiled version generates a totally new version."
it's pretty clear they know this is something that most people would consider to be malware rather than just run of the mill adware. So the blatant disregard for users appears pretty malicious.
That's certainly false. HTTPS does not encode the routing headers, so it's still possible to block all traffic foreign to the host (or coming from a list of suspected malaware/add domains) without decoding the packets.
a) You block post and get requests that go to external domain's which are either blacklisted or non-whitelisted.
a) services hosted on AWS still have specific ips or ip ranges tied to domain names, so even if doubleclick is hosted on AWS there should be no problem ban-listing it.
example: HTTPSwitchboard works quite well with some tuning without any MiTM proxying - as a matter of fact, I'm not sure what you would even gain from MiTM proxying, if an authenticated host wants to serve you malicious content they don't need to cross-domain reference, and you won't be able to distinguish it from non-malicious content.
Proxying and decoding content at some point prior to final destination may be useful in certain very specific cases, but generally it's unnecessary and leads to more dangerous failure modes. So far I haven't seen a typical use-case for it explained, which cannot be achieved with other methods.
The point is that the MITM proxy can scan the traffic for malicious content and block it before e.g. it reaches a browser. HTTPSwitchboard works only in the browser, but that might be too late if it's a browser exploit on a new domain... or a browser that you cannot modify easily, like the embedded ones in various "smart" devices.
The difficulty is identifying the malicious traffic in an automated way, your own machine can scan it to - but most likely your browser is already patched for known vulnerabilities (maybe if someone is still running old IE versions in your office this could be beneficial).
Secondly, you don't need to proxy to scan malicious sites, if you have a dedicated machine (or third-party service) that sees an outgoing request and if the address is not in it's safe-list, it tests that request by duplicating it (you can have a netfilter hook in your firewall blocking packets from 'non-safe' sites or delaying for validation from the dedicated device/service). This doesn't require a MiTM proxy in the SSL connection.
The SSL connection MiTM as far as I understand is only necessary if you want to check for malicious data being injected into an authenticated, non-publicly accessible site or form. Having one dedicated device which is re-routing office traffic through it's own SSL cert means that if that single device is compromised, so is the entire network.
https://www.techdirt.com/articles/20150105/09344429597/gogo-...
By contrast, the GoGo interceptor is going to be a computer somewhere either on the plane or possibly on the ground (at some GoGo data center), meaning that its private key isn't accessible unless you can somehow gain access to the interceptor system.
Too much of choice and too much of competition has made consumer PC laptops shopping an unpleasant experience. Windows Surface Pro 3 however is an amazing device. In my opinion Microsoft should now come with their own laptops made by MS well integrated with Windows Phones, Xbox and Band.
Looking at Komodias webpage, Lenovo could have a hard time defending that they did not know about its possible SSL interception. Failing to understand the impact is Negligence, at least. I would argue that decrypting the traffic is as intended by Lenovo.
[0] http://www.businesswire.com/news/home/20150219006362/en/Kell... [1] http://www.krcomplexlit.com/index.asp?N=attorneys-Seattle-WA...
edit: added original source
If my next laptop isn't from Apple it will be one I can buy from Microsoft directly where they don't install any of that garbage.
They're like the "Gateway" laptops of yesteryear. Thinkpad is still "fine" but Lenovo's consumer stuff is utter junk of the highest order.
Source: Worked at a startup which purchased consumer laptops (shudder). Asus were "fine," Acer/Dell was "ok," Lenovo were horrifying, only being beaten by an unbranded laptop we had.
So I'd highly recommend avoiding Lenovo's stuff unless it is a Thinkpad.
It might be nice for browsers to flag locally installed root certificates and give some kind of visual indication to users but I'm not even sure how easy this is to do because a lot of browsers use the system roots and don't control the roots directly. its easy to identify the extra certs when you control the original roots.
also apparently this doesn't go down too well with corporate users who want to install extra private roots for internal services or for MITM.
| sort | uniq > super.dict
why not | sort -u > super.dictYou have to remember switches for every command, while commands like sort only need to be remembered once.
Accordingly, Unix programmers have learned to think very hard about two other properties when designing APIs, command sets, protocols, and other ways to make computers do tricks: compactness and orthogonality.
Whoops! Never mind...
[0] a part of a city in which members of a particular group or race live usually in poor conditions; the poorest part of a city
> 1: a quarter of a city in which Jews were formerly required to live
http://www.merriam-webster.com/dictionary/ghetto
(Note: I'm not calling the article's author racist, just noting that the above claim about Webster is factually mistaken.)
http://www.npr.org/blogs/codeswitch/2014/04/27/306829915/seg...
Lenovo used to be championed around as the best competitor because of it's hardware, but this comes to light: What do you say to that? For the past 5 years Apple has had the best laptops in the world hands down.
* the os does not feel practical (menu bar on only one screen? No universal home/end? No universal way to jump/select words like (ctrl + ->, ctrl + shift + -> on Windows and Linux) * non-standard keyboard layout, no way to adjust it (specifically fn/end)
Mind you, I am a fan of Macs and recommend friends trying them but I don't want one as long as I cannot afford one laptop for work and another for photos and stuff.
(btw: I didn't downvote you)
What's "the standard" keyboard layout? Looking forward to that one. :)
Good. About time should we say? I left Apple three years ago.
> and you can indeed jump/select words, just substitute Option in place of Control (always been that way AFAIK).
Except if you use another application, then you have to use CMD or fn. But careful, cause in a third application that is a substitute for home/end.
> What's "the standard" keyboard layout? Looking forward to that one. :)
It's easier to tell when someone breaks it:
* Adding shortcut keys on the sides of the keyboard so that I end up starting 5 calculators. (my wifes hp compaq)
* Not putting ctrl in the lower left corner, nor letting me remap it, causing frustration every time I move from the full size Apple keyboard to the laptop or between almost any other machine and an Macbook. (Some thinkpads fails here but at least then you can change it in bios.)
* not having home and end keys nor any consistent way of replacing them.
Again I'm an Apple fan and I am happy that they saved us from older Windows phones but it is not for everyone.
The screen's fantastic, and I guess some people like the shiny metal look. It's got decent hardware, and lots of video out ports. Except, no TPM or other secure storage. And they don't see to take the "let's expose PCIe on outside ports" problem seriously.
Unfortunately, Lenovo is running after them blindly, destroying the work IBM has done on the ThinkPad. I suppose there just aren't enough users with $$$$ to spend to counter the trendy shoppers.
They do? Seems to me that buying an Apple laptop is the most fashionable thing at the moment.
For the past 5 years Apple has had the best laptops in the world hands down.
But don't put those hands down too hard, because the needlessly sharp edges cut into your hands if you do.
Seriously, is it that hard to allow people to have their own preferences?
No it isn't.
http://lcamtuf.blogspot.se/2014/10/psa-dont-run-strings-on-u...
Nothing he said discounts what you added. You should have just said "be careful with strings" and linked your link, rather than making some vague hand waving correction which wasn't...
The actual problem here is that such a dumb simple task as parsing an ELF file isn't something you'll do without vulnerabilities, if you're not paying attention to vulnerabilities. Run `man elf` on your favorite Linux system, and you'll see docs of <elf.h>, which you can use to read ELF files. Write something to just dump the text section -- it shouldn't take you more than like 30 lines of C. Then tell me how many integer overflows you managed to squeeze in those 30 lines. :)
(One quick test: try "strings -n 2 cmd.exe" and see if the output starts with MZ.)
What it can all do by itself is to decrypt data sent from others, or to digitally sign some data.
I would suspect that the bundled private key was used for digitally signing data to show that it was actually generated by the software. The approach is not perfect (since the private key may get decrypted as the author did), but in general it would work effectively for kicking out third party software.
If the developer's intention was to encrypt the data transferred through the public network, then he/she should have used TLS with server-side authentication, with optionally using clear-text credentials transmitted over the encrypted channel to authenticate the software (e.g. basic authentication over HTTPS).
If it gets proved that private information could be decrypted from data transmitted over the public network by using the recovered private key, then this would be an interesting case of misusing public-key cryptography.
There's no doubt that this key can be used to man in the middle user connections, that's what the software it was extracted from is using it for.
I think you did not understand my comment.
It is true that the software is used for MITM. It is true that _Superfish_ is in the middle, decrypting the communication.
OTOH the author claimed that it might be likely for _others_ as well to possibly MITM the communication, by using the recovered key. My comment is that such a situation is unlikely under the premise that the public-key encryption technology was used correctly (from technical standpoint, not ethical).
EDIT: Even if it was the case that the recovered private key was used by the MITM server running locally for communicating with the web browsers, it wouldn't mean that others could use the key to decrypt data transmitted over the wire by using the key, since all the communication encrypted by the key would terminate within the local machine.
EDIT2: Ah sorry, now I understand. The root certificate installed by the adware was using the recovered private key. That would mean that others can MITM the communication by DNS spoofing, etc. together with a server certificate signed with the recoverd key.